Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CMake version examples and bump plugin version #1442

Merged
merged 3 commits into from
Apr 12, 2022
Merged

Fix CMake version examples and bump plugin version #1442

merged 3 commits into from
Apr 12, 2022

Conversation

methylDragon
Copy link
Contributor

🦟 Bug fix

Related to: gazebo-tooling/release-tools#700

Summary

Use *_VERSION_MAJOR variables to aid search/replace scripts.
Also bumps the version.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Apr 12, 2022
@methylDragon
Copy link
Contributor Author

Not sure why the CI is breaking... It broke for the commit when I just had docs changes.

@methylDragon methylDragon mentioned this pull request Apr 12, 2022
Merged
methylDragon and others added 3 commits April 12, 2022 15:21
@methylDragon methylDragon force-pushed the ch3/ign_plugin_ver-fix-and-bump branch from eb16b45 to a1d4b75 Compare April 12, 2022 22:22
@scpeters
Copy link
Member

this will need to be merged to main before the version bumps can be done

@methylDragon
Copy link
Contributor Author

methylDragon commented Apr 12, 2022 •
edited
Loading

Is it an issue if CI seems to be failing? Required CI pass though.

229:   File "/Users/jenkins/workspace/ignition_gazebo-ci-pr_any-homebrew-amd64/ign-gazebo/python/test/testFixture_TEST.py", line 21, in <module>
229:     from ignition.math import Vector3d
229: ModuleNotFoundError: No module named 'ignition.math'

https://build.osrfoundation.org/job/ignition_gazebo-ci-pr_any-homebrew-amd64/8052/console

@scpeters
Copy link
Member

Is it an issue if CI seems to be failing? Required CI pass though.

229:   File "/Users/jenkins/workspace/ignition_gazebo-ci-pr_any-homebrew-amd64/ign-gazebo/python/test/testFixture_TEST.py", line 21, in <module>
229:     from ignition.math import Vector3d
229: ModuleNotFoundError: No module named 'ignition.math'

https://build.osrfoundation.org/job/ignition_gazebo-ci-pr_any-homebrew-amd64/8052/console

that is unrelated to these changes

@methylDragon
Copy link
Contributor Author

Ok, I will merge so that we can carry on with the bump. Required CI is green and this is a relatively trivial change.

@methylDragon methylDragon merged commit e85278f into ign-gazebo6 Apr 12, 2022
@methylDragon methylDragon deleted the ch3/ign_plugin_ver-fix-and-bump branch April 12, 2022 23:35
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-releases-2022-04-27-fortress-citadel/1389/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scpeters scpeters scpeters approved these changes

@chapulina chapulina Awaiting requested review from chapulina

Assignees
No one assigned
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@methylDragon @scpeters @osrf-triage